QLVideo icon indicating copy to clipboard operation
QLVideo copied to clipboard

Update to ffmpeg 5.1; aom 3.4; gas to 9309c67

Open exgphe opened this issue 2 years ago • 5 comments

Update all the dependencies to latest release version

exgphe avatar Jul 24 '22 09:07 exgphe

Nice work

eirnym avatar Sep 10 '22 06:09 eirnym

This fixes a lot of build problems with QLVideo on M2

eirnym avatar Sep 10 '22 10:09 eirnym

It requires some modifications to the building scripts to make it build on Apple Silicon Macs. But my version is too hacky and complex for a pull request.

Le 10 sept. 2022 à 18:36, Eir Nym @.***> a écrit :

 This fixes a lot of build problems with QLVideo on M2

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

exgphe avatar Sep 10 '22 10:09 exgphe

Could you share modifications you've used?

I added a few minor modifications:

  1. search for headers in $(BUILT_PRODUCTS_DIR)/ffmpeg/arm64 (or copy them back to ffmpeg)
  2. exclude arch x86_64 (I haven't installed Rosetta yet and I don't plan to)
  3. replace dylib external libraries with static ones (search and replace in project.pbxproj file). All dylibs are used from Homebrew
  4. I use MacPorts, so paths to these libraries are also going to change a little
  5. Write an installer script to put results from build folder to proper places

As result QLVideo works well for me.

I had no luck to build from Xcode GUI

eirnym avatar Sep 10 '22 13:09 eirnym

Without your patch it was impossible for me to build a proper binary.

eirnym avatar Sep 10 '22 13:09 eirnym

Thanks for the PR. Closing in favour of d6fc176dc9a200aba5ef3987bc6a3542f1affc38

Marginal avatar Nov 14 '22 12:11 Marginal