websocket-client icon indicating copy to clipboard operation
websocket-client copied to clipboard

Library bundling...

Open simplextech opened this issue 5 years ago • 5 comments

More of a question but I do find it odd. Unlike everything else I use when I build a project with this library I end up with 100+ additional files/libraries dependencies that have to be packaged as well. Most other libraries don't pull them all into the build unless required as part of external packages.

Is this purposeful?

simplextech avatar Apr 30 '19 13:04 simplextech

Could you send me a screen? And tell me which version of .NET you are using (.NET Core or .NET Framework). I'm not able to reproduce 100+ additional dependencies, in my apps I always get only one my-app.dll. But I'm not working with full .NET Framework (WinForms, WPF) anymore.

Marfusios avatar Jul 24 '19 11:07 Marfusios

I think multi targeting .NET framework might solve this issue: https://stackoverflow.com/questions/47365136/why-does-my-net-standard-nuget-package-trigger-so-many-dependencies

rayanalsubhi-feenics avatar Nov 21 '19 16:11 rayanalsubhi-feenics

im on .net core 2.1 and the nuget package doesnt auto install all deps. I have to manually search for and install log4net for it to work and it installs tons of dlls. Still complains about missing serilog and nlog, but it works without them. I dont understand why all this log stuff is even needed.

storm37000 avatar Apr 18 '20 22:04 storm37000

I'm gonna try to multi target for 2.0 and 2.1, it should help significantly.

@storm37000 if you are on full. NET Framework check out this project: I've prepared WinForms example. The library currently still using LibLog abstraction, so you are able to use whatever logging library you want. But unfortunately LibLog is now deprecated, so we have to move to more explicit solution, some good man/woman already prepared PR: https://github.com/Marfusios/websocket-client/pull/50

Marfusios avatar Apr 19 '20 07:04 Marfusios

i have to use .net standard for this one since its a plugin for a gameserver called fivem. Since i mainly work with linux servers im probably never going to touch framework, anyways .net core/standard are the future.

storm37000 avatar Apr 19 '20 21:04 storm37000