websocket-client icon indicating copy to clipboard operation
websocket-client copied to clipboard

ChannelReader

Open Odonno opened this issue 1 year ago • 2 comments

Hello @Marfusios

I am just curious about using and exposing a ChannelReader instead of an Observable to consume received data. I understand the multiple benefits that Rx.NET offers, I only have some questions:

  • Have you tried to make the change already?
  • I am also curious about the performance impact of that change.
  • I suppose it won't have a huge breaking change as you can transform an IAsyncEnumerable into an Observable, still providing the same API experience

Thank you.

Odonno avatar Apr 03 '24 18:04 Odonno

Also curious if we should add .ConfigureAwait(false) here https://github.com/Marfusios/websocket-client/blob/c002823c828c56a52a3403b41d0f18682f395309/src/Websocket.Client/WebsocketClient.cs#L465

Odonno avatar Apr 09 '24 15:04 Odonno