coinbase-client-websocket icon indicating copy to clipboard operation
coinbase-client-websocket copied to clipboard

Various updates, fixes and enhancements

Open shaynevanasperen opened this issue 3 years ago • 0 comments

I've exposed the underlying Subject<T> members in the BitstampClientStreams class. This is because I want to be able to stream fake messages for testing my program which uses this library. Although that was already possible by using fake IWebsocketClient objects, that method is very clunky and requires that I send raw text instead of just POCO objects. There is no good reason for hiding the Subject<T> members behind IObservable<T>, so the most straight-forward way to enable easy testing is to just expose the Subject<T> members directly.

Summary of changes:

  • Add missing functionality for authenticated (private) streams
  • Add missing functionality for Auctions
  • Add missing funtionality for Status channel
  • Add missing funtionality for Full channel
  • Fix broken functionality relating to subscribing to channels (message types and channel names were intermixed)
  • Introduce new ICoinbaseWebsocketClient interface
  • Remove superfluous ICoinbaseCommunicator interface and implementation class
  • Refactor to use file-scoped namespaces
  • Remove custom validation utility (so that exception stack traces are raised from the method itself rather than the ulitity method)
  • Replace LibLog package reference with Microsoft.Extensions.Logging.Abstractions (as LigLog is marked as deprecated)
  • Update other NuGet packages to the latest versions

shaynevanasperen avatar Dec 11 '21 18:12 shaynevanasperen