hll_rcon_tool icon indicating copy to clipboard operation
hll_rcon_tool copied to clipboard

`get_public_info` assumes PUBLIC_STATS_PORT is an int

Open timraay opened this issue 5 months ago • 0 comments

The default.env file says that you can prefix PUBLIC_STATS_PORT with 127.0.0.1: to disable access. While the stats can also be disabled through Settings > CRCON Settings > lock_stats_api, this is still useful if you want to disable the HTTP port while leaving the HTTPS port accessible.

The implementation of get_public_info does not account for the case where the variable is prefixed and will error when trying to convert it to an int. If the value cannot be converted to an int it should instead return None.

There might be other instances where this same issue can occur.

timraay avatar Aug 29 '24 22:08 timraay