futwebapp-tampermonkey icon indicating copy to clipboard operation
futwebapp-tampermonkey copied to clipboard

Minimum Bin shows wrong prices

Open MoAshir opened this issue 4 years ago • 9 comments

Capture1 Capture2 As shown in the above pics minimum bin shows wrong prices when search, and it happens pretty frequently Please help Fix this

MoAshir avatar Sep 21 '19 19:09 MoAshir

I presume this issue is understood. What I see happening is that the script will search for the min BIN for a player and display it correctly. When you click the next player, it's like it still has the price for the first player "in the cache" so it will just keep displaying the min BIN for that first player over and over.

i.e. Search min bin for player A (display 250 coins) (correct) Search min bin for player B (display 250 coins) (even if price is not 250 coins) Search min bin for player C (display 250 coins) (even if price is not 250 coins) Search min bin for player D (display 250 coins) (even if price is not 250 coins) etc!

Obviously, this makes the feature unusable.

Just trying to help, apologies if this is understood already and I am spamming up the thread!

Capture

guiseppeshen avatar Sep 30 '19 07:09 guiseppeshen

I've been looking into this and can't seem to find anything wrong. Are you keeping the player the selected while searching for the minimum BIN? Obviously 200 for Griezmann isn't correct.

Can you open the Chrome DevTools to see the console log while searching? Does it also mention 200 as the minimum BIN?

Mardaneus86 avatar Sep 30 '19 18:09 Mardaneus86

Capture

In this example, I search for Vinicius Jr, his price is 6900. And then Hazard at 490,000. That works correctly, and then Sancho, and Sancho comes up at 490,000. Obviously the price for Sancho is wrong.

It is an issue when you are pressing search bin on more than one player in short spaces of time i guess.

Last year, I could click search bin about 5 times in a row, and it would just check each price one by one, no matter what player was selected. the correct price was always put against the correct player. There is definitely something slightly buggy! If i can help in any better way, let me know.

guiseppeshen avatar Oct 01 '19 09:10 guiseppeshen

Ok, clicking multiple searches simultaneously should not be possible in any case, because it uses the underlying page events to get the data. If you are searching multiple players at once, hence generating multiple page views in a very short time, it might be a red flag for EA.

Mardaneus86 avatar Oct 01 '19 13:10 Mardaneus86

I used to do 5 at a time last year without any problem. Occasionally I had to put a CAPTCHA in if I had done about 10 sets of 5 or something. Other than that, it worked great.

But even so, there is still an issue for me even if i slow it down and do one at a time, i often get replicas. Like the Sancho example...

guiseppeshen avatar Oct 01 '19 13:10 guiseppeshen

always I use it searching one by one since 2018, it work searching multiple players but sometimes bugs a lot doing this way (not the correct way to use), but the problem at moment is even searching one by one it have the problem guiseppeshen told, bug for second player and show the last price shown (from the 1st player), but for me it can keep showing the same 1st price 2-6x but sometimes in the 3~4 try it works and show new player price, then bugs again... loop.... I will test now if the problem is about the time space between player searches (will wait 20secs after each price shown to request a new search)

veredic avatar Oct 03 '19 11:10 veredic

@Mardaneus86 can you tell me how much pages search minimum BIN search? as gold players may have more than 30 pages and search minimum BIN seens to search about 3~10 pages of prices will be good to know the right amount to select where to use it.

-> about above: sold more than 30 players already in trade list (watchlist seens to bug a lot more idk why) only 1 bugged when I waited less time. Process did: 1- search minimum BIN 2- list player on market right after the search 3- wait 5-15 secs after new minimum BIN search... and repeat process, went well only one fail, just not price precise/fast as in the past, work more for silver players, gold cheap cards (with lot of cards in market) seens bad to use unless you have the time to wait, better trust futbin prices and put -50~100 less or same price in this case if you want fast sell.

veredic avatar Oct 03 '19 12:10 veredic

The underlying process works as follows and hasn't changed since previous versions:

  1. player search is done without a max buy now
  2. first page is checked for lowest buy now price
  3. search is done again with the lowest buy now of the previous search
  4. step 3 is repeated until it has less than the max amount of items on the page, or none at all

Once that condition happens, the lowest X values (a user setting) are considered and a mean value is calculated based on those.

Currently I have no clue why you guys are getting strange results. I can't seem to reproduce that as of yet 😔

Mardaneus86 avatar Oct 03 '19 15:10 Mardaneus86

I am experiencing the problem too, and it happens sometimes even on first search.

Edit: Added images: that's Sergi Roberto with more than one page of BIN at 2700:

image

While the search BIN returns 2900: image

This comes from a freshly loaded web app tab, the BIN in previuos search (before F5 refreshing the page) was 1700, so the "remeber last" shouldn't be an issue at all. This happens every time, I tried to ,mingle with the number of results but with no success, went back to the standard 5. Let me know if there's something I can do to debug.

tigers75 avatar Oct 04 '19 06:10 tigers75