futwebapp-tampermonkey
futwebapp-tampermonkey copied to clipboard
Mardaneus86
Search minimum bin doesnt work for UCL cards or players who switched clubs
Expected behavior:
Blue championship cards and gold base cards give the correct minimum BIN when using the "Search minimum BIN" feature.
Current behavior:
We get the min BIN for the base gold card when searching for UCL card and we get the cheapest price for a player regardless of club.
Metadata:
- Script version: 1.4.1
- Browser: Google Chrome Version 71.0.3578.98 (Official Build) (64-bit)
- OS: macOS Sierra 10.12.6 (16G1314)
i see that this expected behavior of #118 but im taking maybe we can do better. what if we pass the item to the find() function here: https://github.com/Mardaneus86/futwebapp-tampermonkey/blob/master/fut/transferMarket.js#L229
and then do some filtering to discard the items that dont match the same card type? @Mardaneus86
Since CL cards are returned for the normal gold rating filter, we can't deplete the search results by lowering the max BIN value. There is probably no viable way to do this properly without navigating through all the pages. In the current setup, once we get to 1 page of results, we are sure to have found the minimum BIN.
The find() function is using the search parameters provided by the EA web app. Using any other will probably make you risk a potential ban.
If you know of any other efficient way to do this, feel free to discuss. How would you do it manually?
Why not using the compare price feature? I don't know if it lets you filter by price though.
can't we search for Special Cards instead of gold rating? UCL cards are the cheapest special version card that there are.
#118 claims this is not true, but i just looked in the web app and special card filter does return the UCL card. maybe there used to be a bug with EA when you implemented that change?
i can try commenting out:
if (item.rareflag === 47) { // 47 = Champions // if it is a Champions card, this is seen as a gold card // Can only search for "Gold" in this case searchCriteria.level = factories.DataProvider.getItemLevelDP(true) .filter(d => d.id === 2)[0].value;
to see if i get expected results
@Mardaneus86 ive made a PR to fix this issue. please let me know what you think.
@eroncanc thanks for that. The web app would return CL cards for regular gold filters in the past, and not for specials. There were some exceptions but I couldn't figure out how or why back then.
PS: please edit your comments instead of adding a lot of new ones, otherwise my email inbox explodes 😀
I just tested with Hugo Lloris for example. Using the gold filter still returns CL cards, but so does the Special filter. Looks like the CL cards are treated as Gold and Special. Would be nice if there was a way to get prices of exact versions, but I doubt that is possible.
Noted about editing one comment, sorry about the spam.
"Would be nice if there was a way to get prices of exact versions, but I doubt that is possible."
Why? If the item is gold search for gold. If the item is UCL, search for special. That's what #160 does, why do you think that won't work?
I was talking about other special cards, not just UCL. I doubt we can say with 100% certainty that the UCL cards are always lower priced for all players in the game. Since we can't filter correctly for only UCL cards there is no way around it but to make that assumption (I don't know if that's a valid assumption at this point).
If anyone knows how Futbin manages to find out the min bin for specific special cards, please let me know 😄That would be a big benefit.
I think it is a valid assumption. UCL cards have the same price range as the gold base cards so it will always be cheaper that IF. And let's say there is a rare case where it is not, then the price will still be closer than what the script is currently doing.