futwebapp-tampermonkey icon indicating copy to clipboard operation
futwebapp-tampermonkey copied to clipboard

Colorize rows based on different criteria

Open veredic opened this issue 5 years ago • 15 comments

Hi, are you able to do a similar version of your colorize comparing actual bid price with futbin price?, it will be very good for some of us, thank you for all you've done and fast fifa 19 att =)

veredic avatar Oct 05 '18 22:10 veredic

An example of what could be done. Use the FUT colors (the pink in this case - #f93b78) to color the numbers and a lighter pink color as the row background. Would be super easy to see when scrolling and also not clash too much with the site brand.

fut-row-highlight

charliepratt avatar Oct 10 '18 16:10 charliepratt

I'll give this a try

Regaddi avatar Oct 12 '18 18:10 Regaddi

Should the EA fee (5%) be taken into account when colorizing the row? Or should we just do the comparison between current BIN and FUTBIN BIN?

Regaddi avatar Oct 12 '18 18:10 Regaddi

My opinion would be that since the EA tax applies to every sale, it probably isn't that important to call out. It's sort of a given that you lose 5% in the deal.

charliepratt avatar Oct 12 '18 18:10 charliepratt

Don't need to calculate EA tax, only comparison between current BID and FUTBIN BIN is ok =)

veredic avatar Oct 13 '18 01:10 veredic

regaddi not sure if you get the idea, comparing BIN with FUTBIN already exists, #121 refers to compare current BID with futbin, if current bid is less than futbin price, it highlight the row

veredic avatar Oct 14 '18 01:10 veredic

Ah, seems that I didn't fully get the idea. So the bargain feature already exists in develop. This issue here addresses the comparison between current bid price and Futbin bin, correct? Given the following example: Futbin BIN: 800 Current bid: 250 BIN: 800 The row should be highlighted, but differently than bargain does? Another example without highlighting: Futbin BIN: 800 Current bid: 850 BIN: 900

Is that correct?

Regaddi avatar Oct 14 '18 09:10 Regaddi

I would like to keep this issue more open, as the title suggests, not just to bid or BIN. Thing is we need to be able to keep it understandable for the general public, so not sure if colors are the best way to do this. Maybe markers like the "untradable" items get in the web app? The setup screen for this kind of feature will likely become quite complex. So if you have ideas for that, please discuss here as well.

As I said in Gitter before, I'd like to get an overview of all ideas first, before giving it a go. This way we can think of a good way to visualize all the possible options that you guys would want.

Mardaneus86 avatar Oct 14 '18 10:10 Mardaneus86

Just divide in 2 types of colorize, will be fine for all of us, one kind already exists (compare BIN x FUTBIN), just need to make a second way (with another checkbox for active or not in script configs) with comparison between current BID and FUTBIN (can name bargain 2.0 or auction bargain idk), the function all the people I know asked and at moment need is just compare the actual BID x FUTBIN, in two separated functions: 1- bin x futbin (active or not) (green) 2- actual bid x futbin (active or not) (pink), and if you use one you can't use the other at same time (faster to make), 2.1- or it will show a 3th color for parameters fitting both bargain styles (less buy now and less actual bid than futbin) (orange or any color), you guys decide what is best, 1+2 is fast to make, 2 different functions, 1+2.1 need to mix the things and make it a little more complex. about highlight is fine, it's only 2/3 colors and easy to see the bargains this way, is all we need to know what to bid for/buy or not.

veredic avatar Oct 14 '18 12:10 veredic

i think it would be very usefull to see another colour if the actual bid price is under the buy now price ... for icons and gold players, because the futbin seems to be in time with the prices ... for bronce or silver players its not really usefull if the price is 3 hours ago.

then you can filter some invests ...

dngpower avatar Oct 14 '18 12:10 dngpower

actual bid x buy it now is useless in my view, mostly of gold players are with 10k BIN and less actual bid, so the script will color almost every player, futbin is accurate with gold players, so using futbin instead of only BIN is best in my opinion.

veredic avatar Oct 14 '18 12:10 veredic

oops, using the logic, it will color every player, actual bid always will be less than buy it now xD need to use futbin x actual bid for sure.

veredic avatar Oct 14 '18 12:10 veredic

Other kind of colorize (more useful) can be with a box where you set the minimum difference (profit) between futbin and current BID <-> or/and futbin and BIN example: minimum profit box: 250coins will Colorize only players with difference equal or higher than 250 coins futbin price 600; current bid price 300 = colorize futbin price 500; current bid price 400 = off

veredic avatar Oct 17 '18 07:10 veredic

the version for BID exist from another developer work fine for me with green color but which to have a selection either BIN or BID with a switch if you trade at the 59 min or try to mass bid on card maybe for another topic but is it possible that each element is module that we could choose from instead of having all the feature and fo those feature example and description if not available somewhere thanks

johndundee21 avatar Dec 08 '18 06:12 johndundee21

any solution?

joaomamorim avatar May 25 '19 20:05 joaomamorim