discord-needle icon indicating copy to clipboard operation
discord-needle copied to clipboard

fix(rename): limit thread names to less than 100 characters

Open c43721 opened this issue 2 years ago • 4 comments

Fixes #173 by enforcing string limits before renaming the thread.

c43721 avatar Jul 14 '22 23:07 c43721

Do you know if we can use the max_length option yet with Discord.js? It was added ot the API last week https://discord.com/developers/docs/change-log#min-and-max-length-for-command-options

Would be better UX knowing in advance!

MarcusOtter avatar Jul 14 '22 23:07 MarcusOtter

not sure- don't think so because djs 13.9 isn't out?

c43721 avatar Jul 14 '22 23:07 c43721

discordjs/discord.js#8217 is under v13.9 - IMO, we should wait until then and limit the command itself for better UX.

n1ckoates avatar Jul 14 '22 23:07 n1ckoates

of course it's already been merged :|

wake me up when djs updates

edit: this didn't age well

c43721 avatar Jul 15 '22 00:07 c43721

@MarcusOtter Should we close in favor of #250 ?

c43721 avatar Aug 13 '22 16:08 c43721

Leave it open for a bit, I will implement these changes manually and add you as a co-author to those commits @c43721

MarcusOtter avatar Aug 13 '22 16:08 MarcusOtter

Superseded by #250, added c4 as co-author there (I removed the check as nick suggested)

MarcusOtter avatar Aug 20 '22 00:08 MarcusOtter