mik icon indicating copy to clipboard operation
mik copied to clipboard

Review how we are logging things, particularly exceptions or errors

Open mjordan opened this issue 8 years ago • 5 comments

Coming out of #296, we should centralize logging, particularly problem or error logging. Currently exception logging bubbles up to mik, which has worked well for us so far, but this situation makes it awkward to use the same Monolog logger in manipulators or post-write hook scripts.

Related issue is that the regex at https://github.com/MarcusBarnes/mik/blob/master/extras/scripts/specificsetfromproblemrecords.php#L52 only catches numbers. Once this all settles we'll need to update it to pick out any type of record_id values.

mjordan avatar Nov 25 '16 17:11 mjordan

#199 may be related?

mjordan avatar Nov 25 '16 21:11 mjordan

Also, quasi-related could the logging level be configurable? I'd like to throw some debug level messages in that you'd only need to see it if something is going wrong.

whikloj avatar Jun 29 '17 15:06 whikloj

In #283, @MarcusBarnes proposed a --verbose option. @whikloj do you mean a custom Monolog logging level (like "debug"), or the option to provide greater verbosity?

mjordan avatar Jun 29 '17 17:06 mjordan

@mjordan I'm good with verbosity more verbosity.

whikloj avatar Jun 29 '17 21:06 whikloj

:man_facepalming: I'm good with more verbosity

whikloj avatar Jun 29 '17 21:06 whikloj