Marco Edward Gorelli

Results 418 comments of Marco Edward Gorelli

> Else I'll get back to it when I have a chance probably not gonna have a chance anytime soon - closing then, and I'm sorry about this

In case it's useful to you, as a stopgap solution, you could use pre-commit's own exclude: ``` - repo: https://github.com/econchick/interrogate rev: 1.3.1 # or master if you're bold hooks: -...

I think it should be possible to make the fast iso8601 path respect `exact`, that'd make it unnecessary to add an extra argument - I'm giving this a go (will...

> Just a general question: How would this impact functions like `read_csv`? Thanks for taking a look - in [read_csv](https://pandas.pydata.org/docs/reference/api/pandas.read_csv.html), if parsing a date column fails, then the column is...

Cheers! And yeah if there's an error and the user is using `errors='coerce'` (the default), then `pd.to_datetime(['12-01-2000 00:00:00', '13-01-2000 00:00:00'])` would give ``` ValueError: time data '13-01-2000 00:00:00' does not...

True, it would just show `DatetimeIndex(['2000-12-01', 'NaT'], dtype='datetime64[ns]', freq=None)` Maybe there could be a `verbose` argument which prints out the inferred format, but I'd suggest we keep that to a...

@scott-r the current behaviour is unexpected to many and causes problems, see the many comments in https://github.com/pandas-dev/pandas/issues/12585 and the many linked issues The behaviour of `infer_datetime_format` is also unexpected to...

Thanks for taking a look @srotondo I don't think that would fix the confusion - in https://github.com/pandas-dev/pandas/issues/12585 and linked issues, people are using `to_datetime` without `infer_datetime_format` yet are still expecting...

@Dr-Irv sure, that'd be an option, but if there's gonna be a breaking change, I'd suggest we take the chance to simplify - having `infer_datetime_format` take three different options feels...