MarvelGallery
MarvelGallery copied to clipboard
Review for application proposition
- It cannot be long, while it needs to described in 20-30 pages chapter. It wasn't planned previously and now we don't want to make this part to long. Also, it should not be complex and it should use only simple and standard dependencies. I decided to include RxJava, but I am using only most basic features, which are easy to explain.
- It should show as much Kotlin features as possible. But they need to be used in good way (reasonable).
- We want it to look good (visually).
- We would like structure to be simple, but also clean, because readers might later use it as reference in their own projects. This is why we've decided to implement it in MVP.
I see that structure change outdated most comments, so to keep concerns that were not resoled and are not really outdated:
-
BasePresenter
andBaseActivityWithPresenter
are not needed -
Provider
name is not really descriptive -
CharacterProfilePresenter
might contain view responsibilities
Codecov Report
:exclamation: No coverage uploaded for pull request base (
review@a3026d1
). Click here to learn what that means. The diff coverage is57.27%
.
@@ Coverage Diff @@
## review #1 +/- ##
=========================================
Coverage ? 57.27%
Complexity ? 57
=========================================
Files ? 29
Lines ? 220
Branches ? 13
=========================================
Hits ? 126
Misses ? 83
Partials ? 11
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...lgallery/data/network/dto/CharacterComicWrapper.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...ry/data/network/providers/CalculateAuthParamFun.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...llery/data/network/providers/LoggingInterceptor.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...rvelgallery/data/network/dto/CharacterMarvelDto.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...t/marvelgallery/data/network/providers/Retrofit.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...nt/marvelgallery/data/network/dto/DataContainer.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...lopment/marvelgallery/data/network/dto/ImageDto.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...ment/marvelgallery/data/network/dto/DataWrapper.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...llery/data/network/providers/HeadersInterceptor.kt | 0% <0%> (ø) |
0 <0> (?) |
|
...gallery/data/network/providers/QueryInterceptor.kt | 0% <0%> (ø) |
0 <0> (?) |
|
... and 19 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a3026d1...cc3483b. Read the comment docs.