has-changed-path icon indicating copy to clipboard operation
has-changed-path copied to clipboard

Published 20 hours ago • verified publisher icon MarceloPrado

Add optional `commits` counter

Open boozook opened this issue 2 years ago • 8 comments

Also updated dependencies. Closes #34.

boozook avatar Oct 22 '22 18:10 boozook

Any plans on finishing this and resolving #34 , @MarceloPrado || @boozook ?

RobinTail avatar May 04 '23 12:05 RobinTail

@MarceloPrado

RobinTail avatar Aug 08 '23 13:08 RobinTail

Sorry, unfortunately I have no time as well as forces to resolve conflicts and make improvements to this PR. If anyone could take it, just copy, rebase and do not forget to add a fallback to 1 to keep backward compatibility, that will be awesome.

@RobinTail || @koniuszy 🙄

boozook avatar Aug 08 '23 15:08 boozook

@MarceloPrado do you have time to review and merge PRs? Because I'm planning to open one that resolves all the merge conflict of this PR.

developomp avatar Aug 17 '23 15:08 developomp

@developomp I think this PR is doing to much for a PR. It would be great if you can open a PR that just solves the deprecation. https://github.com/MarceloPrado/has-changed-path/issues/34

Other changes should be done in sperated PRs in my point of view.

Chris53897 avatar Sep 12 '23 07:09 Chris53897

After having a look at master and the the github action runs, i guess this is already fixed.

Chris53897 avatar Sep 12 '23 07:09 Chris53897

Can this PR be closed then?

developomp avatar Sep 12 '23 16:09 developomp

The work from https://github.com/MarceloPrado/has-changed-path/pull/35#issuecomment-1669794258 still needs to be done. I guess the best solution is to create a new PR with just the changes for the function Add optional commits counter. I do not need this function, and the author has no time to finish it. If you want this function, it's probably up to you to create a PR.

Chris53897 avatar Sep 14 '23 13:09 Chris53897