MarceloPrado
[feat]: add support for a callback for activeDayFiller
Addresses this request: https://github.com/MarceloPrado/flash-calendar/issues/76
🦋 Changeset detected
Latest commit: 6883b40984fb096e0456f15d71f759fed41bceaf
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @marceloterreiro/flash-calendar | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
I actually saw you suggested this should be able at any level on theming, which makes a lot of sense, and I would like to work on that contribution! I'll see if I can work on that over the weekend :). Can you please show me an example of tests for components so I can build test suites for this feature? When I worked on this I wanted to add the test but I couldn't find any component tests.
Hey @MarceloPrado, can we move forward with this PR? Would love to include it in my next release! Thank you.
@MarceloPrado i see the package has been gaining some popularity lately! If you are interested on supporting this, let me know :)
hi folks, sorry! I need to improve my GH notifications setup.
@isaiasdearcog for testing, I'm currently using storybook - no snapshot testing yet, just a story dedicated to this feature that we can run and explore if things are working. In the future, we could use something like Chromatic to snapshot each story.
For the purpose of this PR, it would be good to see a few stories testing the feature. You can attach a video of your simulator going over them
@isaiasdearcog added the missing test here: 9f2d5f1
https://github.com/user-attachments/assets/6e2b5f99-f0c8-4b89-b3a6-dadb8a87a71e
Will merge this PR and publish the next version. Thanks for your contribution!