awesome-streamlit icon indicating copy to clipboard operation
awesome-streamlit copied to clipboard

Contribution of app

Open lyqht opened this issue 4 years ago • 5 comments

Hello! I would like to contribute my streamlit project that was done for a school course!

Website: https://playstore-analytics.herokuapp.com/ Github link: https://github.com/lyqht/googleplaystore-analytics Please guide me on how to do this and if i should make any revisions, thank you!

lyqht avatar Feb 04 '20 03:02 lyqht

Hi @lyqht

That sounds awesome.

If you know how to you can

  • fork this repo
  • add your app to a subfolder of the gallery folder
  • add your app to the apps_in_gallery.py file.

You can see a similar contribution of changes here https://github.com/MarcSkovMadsen/awesome-streamlit/commit/77ed2a37f7ec01834f5a9904d414beaff2cdcc70.

Just reach out if you need more info or help.

MarcSkovMadsen avatar Feb 05 '20 19:02 MarcSkovMadsen

Just took a look at your app. It's really great and would add something a little bit different and inspiring to the gallery. That would help a lot of others.

One suggestion. I think the plots are awesome but they are not interactive. You could consider using something like bokeh/ holoviews/ hvplot, pandas or altair to make them interactive.

I hope you still have the motivation to contribute it. Let me know if you need anything.

MarcSkovMadsen avatar Feb 05 '20 19:02 MarcSkovMadsen

Thanks for a reference contribution! I'll look into the recommendations that you have given me first to make the plots more interactive before making the pull request then. 😃

lyqht avatar Feb 06 '20 01:02 lyqht

You are welcome to contribute the app first. Its already very awesome. Then you can improve the plots when and if you have the time and energy. :+1:

MarcSkovMadsen avatar Feb 06 '20 03:02 MarcSkovMadsen

Ohh, okay then :D I'll submit the PR soon, thank you for your guidance!

lyqht avatar Feb 06 '20 03:02 lyqht