AmazonProductAPI icon indicating copy to clipboard operation
AmazonProductAPI copied to clipboard

added ReponseGroup parameter

Open mrvnklm opened this issue 7 years ago • 3 comments

If no parameter is set, all default responseGroups as before are used, so there shouldn't be any issue for existing usages.

Might help #29 Fixes #30

mrvnklm avatar Aug 03 '18 08:08 mrvnklm

@MarcL Please merge if you're fine with my changes.

mrvnklm avatar Dec 27 '18 12:12 mrvnklm

Hey @mrvnklm. Sorry, I don't really use this project myself so I've not looked at it in a long time.

Your changes are ok but you've changed the signature of the methods by putting the response groups as a 2nd parameter so it's broken the current API. What do you think about putting this as the last parameter and defaulting it? If not, then we'll need to create a new major version with breaking API changes and needs documentation updating.

Doesn't look like this will fix #29 as that's not supported in the API.

Thanks, Marc

MarcL avatar Dec 30 '18 11:12 MarcL

@MarcL should be fine now, please check

mrvnklm avatar Jan 06 '19 22:01 mrvnklm