AmazonProductAPI icon indicating copy to clipboard operation
AmazonProductAPI copied to clipboard

Needs more tests

Open MarcL opened this issue 8 years ago • 3 comments

Need to add some more tests for AmazonAPI

  • Test data transformations work as expected
  • Test double for HttpRequest
  • Check expected Amazon signature for signed requests

MarcL avatar Aug 21 '17 19:08 MarcL

Added some in #17 and #18.

MarcL avatar Nov 13 '17 22:11 MarcL

$this->amazonAPI = new AmazonAPI($urlBuilder, 'simple'); [

{
asin: "B01KA7VWWC",
url: "https://www.amazon.com/Coffee-Brewer-System-Carafe-CF091/dp/B01KA7VWWC?SubscriptionId=XXXXXX&tag=XXXXX-XXXX&linkCode=xm2&camp=2025&creative=165953&creativeASIN=B01KA7VWWC",
rrp: 199.99,
title: "Ninja Coffee Bar Brewer System with Glass Carafe (CF091)",
lowestPrice: 151.76,
largeImage: "",
mediumImage: "",
smallImage: ""
}
]

The images arent returned. But if we check the json version of it, we can see the images being returned.

prakashchhetri avatar Jan 03 '18 06:01 prakashchhetri

Can you raise a new issue please @prakashchhetri? Thanks.

MarcL avatar Jan 03 '18 08:01 MarcL