Marc Berliner

Results 25 comments of Marc Berliner

To improve the performance, you can pass a function with the time-varying current instead of starting and stopping the simulation. First, create an interpolation object of your time-series data using...

To clarify, is your simulation failing at high temperatures but you still want to receive the output?

This isn't explicitly accounted for, but there is a workaround. Say you want to run a CC-CV simulation ```julia p = petlion(LCO) sol = simulate(p, I=5, SOC=0) simulate!(sol, p, V=:hold)...

Here are my thoughts on improving the solver. Please let me know if you have comments or questions @martinjrobins and others. ### Solver options - [x] https://github.com/pybamm-team/PyBaMM/pull/4282 ### Initialization -...

> Would this play nicely with the casadi solver? If we can access IDA's internal time steps via Casadi, I think we can do most of this stuff

To improve the speed of our ODE models, I'd like to add `CVODE` from SUNDIALS to our suite of C solvers in addition to `IDA`. I have a few questions...

I think we cannot yet combine `output_variables` with `experiment` arguments (I don't see any tests that cover this use case). @pipliggins, @BradyPlanden, do you know if this might be the...

> recording frequency based on both time and voltage intervals (e.g. record every second or every 1mV) @valentinsulzer are you imagining this as a post-processing step to simplify reporting or...

Hi @isaacbasil, there are some known issues related to the time-dependent heaviside function (see https://github.com/pybamm-team/PyBaMM/pull/4994). As a workaround, can you please try evaluating the numeric value for `t_cut_p` and adding...

@isaacbasil this workaround fixed it for me. Try replacing the `t_cut_p` line with ```python regime_p = (2 * pybamm.t < 2 * t_cut_p) ``` Pybamm tries to be fancy if...