Marc-Spector

> what are the FilterNames used for? Filter names are necessary because different places use a specific set of filters where the same data type will be filtered. They will...

I did not complicate everything and removed the concepts of "primary" and "secondary" filters. All the specified filters are always visible

I think it would be nice to add a counter of how many elements are hidden for each filter. I can make it optional. This complicates the code. I won't...

I will also replace `Show` word with`Hide` in the `Show private games` and `Show modded games` filters to maintain consistency in other places

I did not expect the PR to be big. :)

I found another case. Apparently, this is the common issue. 

I see 2 players in the message ``` 2022-04-23 22:24:37.484 DEBUG 14016 --- [reactor-tcp-nio-1] com.faforever.commons.lobby.FafLobbyApi : Inbound message: {"command":"game_info","visibility":"public","password_protected":true,"uid":16870961,"title":"test","state":"open","game_type":"custom","featured_mod":"nomads","sim_mods":{"1491f3be-41f1-4427-9d84-e3524ac1051e":"All Faction T1 Engineers","65351074-D4A7-4449-B690-A3FCBE279341":"Crazyrush Anywhere","BBEFBDF1-3C21-4CD6-89EE-86EA42218C0C":"OOF ACU Death Sound"},"mapname":"scmp_009","map_file_path":"maps/scmp_009.zip","host":"Dexruus","num_players":2,"max_players":8,"launched_at":null,"rating_type":"global","rating_min":null,"rating_max":null,"enforce_rating_range":false,"teams":{"2":["Dexruus","LFS_Pazifisto"]}} ``` 

It looks like I found a connection between all the cases. This is due to the underscore symbol in the name of the missing player

https://github.com/FAForever/downlords-faf-client/issues/2678#issue-1213411581 - `Michael_Ice` ``` 2022-04-23 22:20:52.870 DEBUG 14016 --- [reactor-tcp-nio-1] com.faforever.commons.lobby.FafLobbyApi : Inbound message: {"command":"game_info","visibility":"public","password_protected":false,"uid":16870861,"title":"All welcome","state":"playing","game_type":"custom","featured_mod":"faf","sim_mods":{},"mapname":"scmp_009","map_file_path":"maps/scmp_009.zip","host":"prefuzek","num_players":8,"max_players":8,"launched_at":1650741651.2251167,"rating_type":"global","rating_min":0.0,"rating_max":1500.0,"enforce_rating_range":false,"teams":{"2":["prefuzek","Holongit","Mariono","Cocodoo"],"3":["Heroinkid","Thibor","fedorafreak","Michael_Ice"]}} ``` https://github.com/FAForever/downlords-faf-client/issues/2678#issuecomment-1107604785 - `memento_MORI_` ``` 2022-04-23 22:12:10.020 DEBUG 14016 --- [reactor-tcp-nio-1] com.faforever.commons.lobby.FafLobbyApi : Inbound...

No player in observers - `Altf4_ubivator` ``` 2022-04-23 22:37:50.465 DEBUG 14016 --- [reactor-tcp-nio-1] com.faforever.commons.lobby.FafLobbyApi : Inbound message: {"command":"game_info","visibility":"public","password_protected":false,"uid":16870925,"title":"1.2k+ opti","state":"open","game_type":"custom","featured_mod":"faf","sim_mods":{},"mapname":"dualgap_adaptive.v0012","map_file_path":"maps/dualgap_adaptive.v0012.zip","host":"frollog","num_players":12,"max_players":12,"launched_at":null,"rating_type":"global","rating_min":1000.0,"rating_max":null,"enforce_rating_range":false,"teams":{"2":["frollog","na_dno","OldStudent","Vast","K240","BeshbarMak"],"3":["GL_HF","cZARJc","Shaktti","Jackataj","Fat_Bustard"],"-1":["Altf4_ubivator"]}} ```