say.js icon indicating copy to clipboard operation
say.js copied to clipboard

Project probably has security vulnerabilities

Open tlhunter opened this issue 6 years ago • 0 comments

This project most likely has security vulnerabilities. If an attacker is able to craft any string being spoken then it's likely such a string can be used for command injection.

Such security implications are probably going to change between MacOS/Linux vs Windows/Powershell.

The text and voice arguments need to be cleaned up before being passed to the commands. voice should have a strict subset of characters, and text should probably replace all special characters such as / with FORWARD SLASH.

tlhunter avatar Jun 12 '19 18:06 tlhunter