Marak

Results 332 comments of Marak

No, this is not good. Why did you copy and paste all this code here for no reason? Don't do that.

@rcs - Perhaps using `qs` library? https://www.npmjs.com/package/qs

@tlhunter - Yes, the command would essentially mimic the basic functionality of the existing `say` command on Mac OS, but it would also provide all the additional options `say.js` has.

I'm a little confused what the API would like look for this. Could you show me some sample usage syntax?

I'm not sure how I could do the arguments parsing without making the salts "utf-8", "ascii" and "hex" reserved? Would that be your solution? How can I tell the difference...

pass null as the second argument?

I think, ``` var md5 = hash.md5(user_password, 'utf-8'); ``` and ``` var md5 = hash.md5(user_password, null, 'utf8'); ``` makes the most sense, where in the first example, 'utf-8' happens to...

Cool, I will review and bump in the next few days.