colors.js
colors.js copied to clipboard
Marak
Added support for orange and bgOrange
@portgasd666 Was this ever merged? If not, is there a branch which has this added?
Doesnt work for my computer. And ansi code 38 is fully supported for my machine
Is there some reason orange isn't always supportable? See comments at bottom of #123 ... generally this seems like it should be merged, but feels like a little extra clarity is needed (either here, in the docs, etc.) about why orange is different and why it might/might not work in different environments...
Orange is not an ANSI color, would something like #76 be preferred? (Just all-out support custom colors... why stop at orange...)
I'm guessing if certain colors and styles work on some systems ( but not all systems ), we should consider adding the API methods.
For example, if orange method is supported for some shells we should allow that color. If a user attempts to use orange in a non-supported environment, we could produce a warning message based on feature detection of the environment.
I'm guessing for additional colors we'll want to add true color / 24 bit color mode. Maybe look at https://github.com/irisli/fullcolor for inspiration. Might make sense to wrap all this under that functionality.
