colors.js icon indicating copy to clipboard operation
colors.js copied to clipboard

Support light colors

Open wdavidw opened this issue 10 years ago • 7 comments

I could find support for light colors so unless i'm mistaken, that would be a nice addition.

console.log '\u001b[33m yellow \u001b[39m'
console.log '\u001b[1;33m ligth yellow \u001b[39m'

Note sure how you would prefer this to be implemented: creating addition colors like colors.lyellow or using colors.light just as colors.dim (cleaner but probably much harder to write). Let me know if you are insterested and i'll take care of it.

wdavidw avatar Jan 16 '15 16:01 wdavidw

+1 to this.

_Caveat: following feedback is Mac-based_ Also, for what it's worth @wdavidw, I would think a bright modifier would be the way to go. For example: .yellow.bright or simply .yellowBright mainly because "bright" is the word that is used in the "ANSI Colors" section of Terminal's Settings. I'm thinking about making a pull request for this, but you mentioned that you had wanted to take care of it, so let me know if I can help :)

Furthermore, it might be worth mentioning in the README that the user can sort-of bypass the need for the bright modifier by using the "Use bright colors for bold text" Terminal setting. However, with the current repo, this only covers text color and not background color.

psullivan6 avatar Apr 07 '15 15:04 psullivan6

Please go hahead if u'd like, im quite overloaded for the next few days

wdavidw avatar Apr 07 '15 17:04 wdavidw

Just noticed a pull request for this #128

SeanBannister avatar Aug 20 '15 19:08 SeanBannister

Good, so we could close this once #128 is accepted

wdavidw avatar Aug 20 '15 20:08 wdavidw

Any updates on this?

widget- avatar Sep 16 '15 19:09 widget-

Ping?

woverton avatar Apr 01 '16 15:04 woverton

See discussion at https://github.com/Marak/colors.js/pull/128 -- reviewing this and planning to merge it in the very near future.

DABH avatar Feb 13 '18 21:02 DABH