guzzle-bundle icon indicating copy to clipboard operation
guzzle-bundle copied to clipboard

Published 20 hours ago • verified publisher icon Mapudo

Add support for Symfony 5

Open mleczakm opened this issue 4 years ago • 6 comments

mleczakm avatar Apr 28 '20 05:04 mleczakm

Looks good. However, I don't have any php tools anymore on my pc (since I'm not developing in php anymore). I asked in issue https://github.com/Mapudo/guzzle-bundle/issues/28 if someone could lcheck this. 👍

Otherwise I will get some php tools on my pc, however, could take a week or two.

kobelobster avatar May 07 '20 14:05 kobelobster

Are the namespace changes really compatible back to Symfony 2.8? I would imagine they are not and a new major library release is necessary at which point now incompatible Symfony versions need to be dropped.

advancingu avatar May 07 '20 14:05 advancingu

Unfortunately, my PR is wrong and it is no longer compatible with old version of Symfony - latest supported version may be 4.2 but I didn't verify it very carefully.

ATM we are using it with Symfony 5.0 and it works OK (we are using fork), so I don't have much time for testing - I will try to fix this on weekend, but I can't promise anything ;)

mleczakm avatar May 07 '20 19:05 mleczakm

@advancingu We at least have an open issue to remove support for <= 3.2.

@mleczakm What does your fork look like? In the linked issue they said they just added |~5.0 to the composer stuff, is that all that is required?

kobelobster avatar May 08 '20 07:05 kobelobster

@kobelobster there are more changes required (all of them are provided in current PR) to get it working

mleczakm avatar May 08 '20 07:05 mleczakm

@mleczakm

Okay, what I could imagine would be this.

The currently maintained Symfony versions are 3.4, 4.4 and 5.0 https://symfony.com/releases

3.4 will be in security mode starting near end of 2020 and only receive security fixes.

Although, a few questions, maybe you could answer them 😊👍 ?

  • In your PR you removed symfony/monolog-bundle for 4.0. Intentional? Shouldn't this be re-added for 4 AND 5 as well?
  • Like @advancingu said: Do the namespaces alsoo work in Symfony 4.4?

So, this would leave us with this

  • Add support for Symfony 5
  • Verify the bundle works for Symfony 4 and 5
  • Remove support for Symfony 3 (in master, so upcoming releases only)
  • Bump version to 3.0.0
  • Refer in README.md that we still support 3.4, however no new features are developed and people should use the 2.3.0 version

Note: If the interfaces don't work on 4.4 I would say we create 3.0.0 with 4.4 support (without the adjusted namespaces) and then create a new branch 5.0 for symfony 5.0 support.

Thoughts?

kobelobster avatar May 08 '20 09:05 kobelobster