Mapster icon indicating copy to clipboard operation
Mapster copied to clipboard

Refactor IMapper.From to return interface

Open gritcsenko opened this issue 3 years ago • 0 comments

Refactored IMapper.From<TSource>() to return new interface ITypeAdapterBuilder<TSource> instead of concrete class.

FYI: Mapster.EF6 & Mapster.EFCore uses outdated package version and causes compilation errors in Mapster.EFCore.Tests and Sample.AspNetCore

Closes #376

gritcsenko avatar Jul 18 '22 00:07 gritcsenko

@gritcsenko The master branch should be in better shape now with EF Core 6.0. Could you please sync your branch and see if the build errors have gone away? And if so, run the tests as well? Thanks! :)

andrerav avatar Sep 05 '22 13:09 andrerav

@gritcsenko I synced the fork and fixed a few build errors. Everything now builds and all tests are passing. Can you take a look at my changes and verify that they are good?

andrerav avatar Sep 06 '22 11:09 andrerav

@gritcsenko I synced the fork and fixed a few build errors. Everything now builds and all tests are passing. Can you take a look at my changes and verify that they are good?

@andrerav Thanks for the update. Everything looks good. My only concern is that public API was changed

gritcsenko avatar Sep 06 '22 13:09 gritcsenko