MAD icon indicating copy to clipboard operation
MAD copied to clipboard

weather_boosted_condition never set for raids webhook

Open JabLuszko opened this issue 3 years ago • 2 comments

We have code for sending weather in raids webhook https://github.com/Map-A-Droid/MAD/blob/3a1d88cc252e16cb88f9b91f86489827fb52673c/mapadroid/webhook/webhookworker.py#L323 but the underlying data in DB is never updated.

No idea what should be here - current weather or only when it is actually boosted? Probably worth to see what RDM/Poracle/PA does/expect here and adjust it to current situation.

redis caching would need weather in key, I guess.

JabLuszko avatar Mar 30 '21 15:03 JabLuszko

Just check the raw data I guess? If the data isn't set via the GMO, there's nothing we can do about unless there's a way to calculate it from the CP or something.

sn0opy avatar Mar 30 '21 15:03 sn0opy

Is this still an issue? I think there was a PR around webhooks but not positive what it was addressing.

Expl0dingBanana avatar Aug 24 '21 10:08 Expl0dingBanana