Manuel Hentschel
Manuel Hentschel
> Some technical clarification to graphics devices upfront: ... Thanks for the explanation! If I understood everything correctly, I'd stick to a similar scope as the included viewer and use...
> Also I saw that, you currently load the SVG directly inside the HTML, in the viewer I wrote I rust use an `` tag. With that the implementation might...
> I am a bit reluctant to add special cases to the renderer, as I want each SVG to be as close to the representation dictated by the R graphics...
You could simply open a new PR at vscode-R, I'll be able to add to that. I can close the other PR or we just leave it up as Proof...
Thanks for the clarification, that was something I wanted to ask about as well. In the latest commit, I tried to adjust the `refreshPlots` and `checkState` methods to only request...
Distinguishing between "closing" and "hiding" feels like a sensible approach. In the last commits, I added commands for both. The "x" Button in the title bar hides a plot, holding...
Regarding the dynamic resizing of plots: Do plots have a natural/preferred size or aspect ratio, independent of the viewer? If yes, is this individual to the plot or the same...
I added a movable divider below the plot, as you suggested. Getting this to work smoothly was a bit of a pain, but for now I think the resizing feels...
Thanks for the feedback! > * In my opinion the horizontal padding of the iframe is a bit to much. setting `body { padding: 0; }` looks better in my...
> The regex in `getPanelPath()` returns `undefined`, because `dummyUri.toString()` looks like this `'vscode-webview-resource://589df09e-e701-49a4-9aa9-5afeb09a321fc/file///'`. > [...] > Edit: [Ikuyadeu/vscode-R@6419752](https://github.com/Ikuyadeu/vscode-R/commit/64197521b9195f0a0aaaad250722dc71c98eb736) fixed the problem thanks! Glad the fix works, though I'm a bit...