ngx-responsive
ngx-responsive copied to clipboard
contrubition instructions + repo cleanup
Hello,
I would like to contribute to this package (I need an Angular Universal support). Are you going to update your contribution.md file? There is also a lot of cleanup todo here (we could remove all lines not related to ts, create travis job etc. etc.)
Hi @maciejtreder, Sounds good, you're free to change all this. Make a pull request with the changes and I add you as a contributor to github and npm.
Hello,
I'm trying to create a patch, and want to try it locally in my project, After cloning the repo, build and link, (and updating main file path), I still can't use it as I have this error :
ScAppComponent_Host.ngfactory.js? [sm]:1 ERROR Error: StaticInjectorError(ScAppModule)[OrientationInfoRx -> InjectionToken Platform ID]:
StaticInjectorError(Platform: core)[OrientationInfoRx -> InjectionToken Platform ID]:
NullInjectorError: No provider for InjectionToken Platform ID!
at NullInjector.push.../../../../node_modules/@angular/core/fesm5/core.js.NullInjector.get (core.js:3228)
at resolveToken (core.js:3473)
at tryResolveToken (core.js:3417)
at StaticInjector.push.../../../../node_modules/@angular/core/fesm5/core.js.StaticInjector.get (core.js:3314)
at resolveToken (core.js:3473)
at tryResolveToken (core.js:3417)
at StaticInjector.push.../../../../node_modules/@angular/core/fesm5/core.js.StaticInjector.get (core.js:3314)
at resolveNgModuleDep (core.js:19784)
at _createClass (core.js:19831)
at _createProviderInstance (core.js:19801)
Anybody know how to correctly link and use this package locally ?
Strangely if instead of linking I replace the files in node_modules it just work.
I don't really understand.