ngx-responsive icon indicating copy to clipboard operation
ngx-responsive copied to clipboard

ngx-responsive fails on Angular 10

Open bjornharvold opened this issue 4 years ago • 4 comments

https://next.angular.io/guide/deprecations#modulewithproviders-type-without-a-generic

Compiling TypeScript sources through ngc
ERROR: node_modules/ngx-responsive/responsive.module.d.ts:15:49 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

15     static forRoot(config?: IResponsiveConfig): ModuleWithProviders;
                                                   ~~~~~~~~~~~~~~~~~~~

An unhandled exception occurred: node_modules/ngx-responsive/responsive.module.d.ts:15:49 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).

15     static forRoot(config?: IResponsiveConfig): ModuleWithProviders;

bjornharvold avatar Jul 04 '20 08:07 bjornharvold

PR here: https://github.com/ManuCutillas/ngx-responsive/pull/152

bjornharvold avatar Jul 04 '20 08:07 bjornharvold

When can we expect this fix to be merged and released? We need ngx-responsive in angular11

stephenmaguireland avatar Dec 18 '20 16:12 stephenmaguireland

Hi, as it has been already merged, have you planned to release it in the near future?

marcinmilewicz avatar Mar 03 '21 10:03 marcinmilewicz

Hello we created a new nx workspace to keep some ngx libs up to date.

We added also the ngx-responsive lib, it should work out of the box you have only to change the import path. We migrate it also to ng12, if you like please have a look

https://github.com/lanthings/ngx-components

npm i --save @lanthings/ngx-responsive

mburger81 avatar Sep 17 '21 13:09 mburger81