Manta icon indicating copy to clipboard operation
Manta copied to clipboard

Update tx-pause pallet to make it easier to pause stuff

Open ghzlatarev opened this issue 2 years ago • 0 comments

Description

closes: #769

  • Splits the UpdateOrigin to PauseOrigin and UnpauseOrigin . PauseOrigin can be both technical committee (1/2) or governance. UnpauseOrigin is only governance
  • Added a list of unpausable pallets - governance + balances
  • ~~Add a special case for function name txp_pause_all_pallets which signifies that the whole pallet is filtered and added a new pause extrinsic that accepts an array of pallet names, to make it easier to pause en-masse quickly. Again the pause-origin is used.~~
  • add pause_pallets and unpause_pallets where parameter is pallet_name, while function_names is get from metadata by GetMetadata trait
  • add pause_transactions and unpause_transactions which parameter is both pallet_name and Vec<function_name>
  • NOTE: MaxCallNames is used for (pre-charge) weight calculation, and it means the extrinsic count of one pallet, current setting to 10. or we may increase to 20?
image

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

  • [x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [x] Added one label out of the L- group to this PR
  • [x] Added one or more labels out of A- and C- groups to this PR
  • [x] Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

ghzlatarev avatar Aug 24 '22 12:08 ghzlatarev