nrwl-nx-action icon indicating copy to clipboard operation
nrwl-nx-action copied to clipboard

feat: update arguments, remove maxParallel and change parallel to number

Open tc-developer01 opened this issue 2 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines
- [x] Tests for the changes have been added (if applicable)
- [x] Docs have been added / updated (if applicable)

PR Type

What kind of change does this PR introduce?

Update the parallel / maxParallel arguments to correspond to the changes introduced in #7677 in nrwl/nx

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [x] Other... Please describe: Correspond to changes made in nrwl/nx

What is the current behavior

parallel is type boolean and defaults to false maxParallel is type number

What is the new behavior

parallel is type number and defaults to 3 maxParallel is removed

Does this PR introduce a breaking change

- [x] Yes
- [ ] No

maxParallel was removed and parallel should be used instead (and it defaults to 3 instead of false which may break existing implementations that do not work correctly when expecting not to run in parallel)

How to mitigate:

e.g. change from

    - parallel: false

to:

    - parallel: 1

or change from

    - parallel: true
    - maxParallel: 5

to:

    - parallel: 5

Other information

tc-developer01 avatar Jul 06 '22 12:07 tc-developer01

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Jul 06 '22 12:07 sonarcloud[bot]

Hi @tc-developer01, sorry for this long time. I've checked out your modifications directly on main. This was just released under v3!

Thanks again for your contribution!

jeremylvln avatar Oct 21 '22 12:10 jeremylvln