FIX: `tof_indices`

Open guoci opened this issue 3 years ago • 2 comments

Apr 23 '22 20:04 guoci

Hey. I was not aware there was an offset error in my tof indices. Looking at the diffs, you seem to suggest that this is due to the scan ordering (which I agree always felt somewhat funky and bug-susceptible, but I was under the impression that this is also the way Bruker stores their data). Do you have an example dataset where this happens?

Apr 25 '22 06:04 swillems

This change should cause some difference in most files. I think the algorithm does cumulative sums over tof_indices in partitions specified by scan_indices. So if last_scan is not 0, that will cause a difference.

Apr 25 '22 14:04 guoci

Hi @guoci . Sorry for not following up on this any sooner. You are completely right about this bug and have the right fix. Since we are several versions ahead by now, I copy-pasted your fix to avoid any merge conflicts. It will be released in the next version of AlphaTims (currently available on the dev branch).

Dec 07 '22 12:12 sander-willems-bruker