compiletest-rs icon indicating copy to clipboard operation
compiletest-rs copied to clipboard

compare_output() fails on Windows due to different line endings

Open fkohlgrueber opened this issue 5 years ago • 1 comments

I described the issue in rust-lang/rust before (link).

As noted in that issue, all one needs to do is to create a .gitattributes that forces LF line endings on checkout.

Do you agree that a .gitattributes file should be added to this repo? It might also be a good idea to make this information part of the docs.

I can open a PR if you want me to.

fkohlgrueber avatar Jan 11 '19 21:01 fkohlgrueber

Hi @fkohlgrueber I totally missed this issue being posted, I'm sorry!

Do you agree that a .gitattributes file should be added to this repo? It might also be a good idea to make this information part of the docs.

If that's all it takes to fix it, I have no problem with it, but I don't really have a good way of testing it myself.

I can open a PR if you want me to.

Please do :-)

laumann avatar Mar 12 '19 04:03 laumann