manim
manim copied to clipboard
Fixing files with few typing (mypy) errors
Overview: What does this pull request change?
In this pull request I have addressed some of the files with only a few reported mypy errors.
Further Information and Comments
To identify files with few mypy errors, I cleared the mypy.ini file so no detected errors would be ignored and then used the follwing command
uv run pre-commit run mypy --all-files | grep "error" | sed 's/:.*//' | uniq -c | sort -n -r
I hope that this approach will make it easier to deal with the large files that needs a lot of type annotations added.
Reviewer Checklist
- [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
- [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
- [ ] If applicable: newly added functions and classes are tested
Thanks for your detailed comments. I have addressed all of the raised issues, in most cases by accepting your suggestions.