manim icon indicating copy to clipboard operation
manim copied to clipboard
verified publisher icon ManimCommunity

fix config file

Open PetarSPal opened this issue 9 months ago • 2 comments

https://github.com/ManimCommunity/manim/issues/4184

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • [ ] If applicable: newly added functions and classes are tested

PetarSPal avatar Mar 15 '25 03:03 PetarSPal

The problem I saw and tried to address is that the removed code was reimplementing make_config_parser.

I don't think it would be an issue to add back the prompting, I'll check and get back.

PetarSPal avatar Apr 21 '25 15:04 PetarSPal

Yeah I read the Documentation for Configuration of Manim, this update_cfg at line 62 is completely useless, Your approach is nice. and Yeah I agree with you, getting prompts form user will be good, at least for those who don't wanna read documentation.

Vanshanium avatar Apr 24 '25 14:04 Vanshanium