manim icon indicating copy to clipboard operation
manim copied to clipboard

Adding type annotations to manim.utils.*

Open henrikmidtiby opened this issue 1 year ago • 2 comments

Overview: What does this pull request change?

The PR adds type annotations to some of the elements in manim/utils

Motivation and Explanation: Why and how do your changes improve the library?

Type annotations are a good thing.

Further Information and Comments

I have chosen to go for smaller PR regarding adding type annotations. The endeavor of https://github.com/ManimCommunity/manim/pull/3981 is a bit frightening...

Reviewer Checklist

  • [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • [ ] If applicable: newly added functions and classes are tested

henrikmidtiby avatar Nov 04 '24 21:11 henrikmidtiby

@JasonGrace2282 Would you take a look at this PR?

henrikmidtiby avatar Nov 05 '24 17:11 henrikmidtiby

I'll take a look when I find the time.

JasonGrace2282 avatar Nov 05 '24 17:11 JasonGrace2282

@chopan050, thanks for all the comments. I have addressed most of them in the code, as well as rebased the changes on top of the current main branch. For the future I will go for smaller pull requests, at it is quite difficult to maintain the overview of this one.

henrikmidtiby avatar Jan 01 '25 19:01 henrikmidtiby