manim icon indicating copy to clipboard operation
manim copied to clipboard

#3741 Treat the media_embed config value as a boolean so it is correctly set to True if using Google Colab

Open skusel opened this issue 1 year ago • 0 comments

Overview: What does this pull request change?

Allows videos to be embedded when running in Google Colab without having to explicitly set the media_embed configuration option to True.

Motivation and Explanation: Why and how do your changes improve the library?

Addresses #3741

Links to added or changed documentation pages

N/A

Further Information and Comments

After making this change, I created a whl using poetry build, uploaded it to Google Colab, pip installed the whl, and confirmed it displayed the embedded video.

manim_google_colab

Reviewer Checklist

  • [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • [ ] If applicable: newly added functions and classes are tested

skusel avatar Oct 23 '24 22:10 skusel