manim icon indicating copy to clipboard operation
manim copied to clipboard

MarkupText ul tag does not work

Open dandavison opened this issue 1 year ago • 2 comments

Description of bug / unexpected behavior

This fails with ValueError: Unknown tag 'ul' on line 1 char 13

class MarkupExample(Scene):
    def construct(self):
        text = MarkupText("<ul>underlined</ul>")
        self.add(text)

Expected behavior

The docstring in the code indicates that it should produce underlined text: https://github.com/ManimCommunity/manim/blob/9a84ec6a45f2ff4254d2243116f84bac074db551/manim/mobject/text/text_mobject.py#L897

Note that this does work:

class MarkupExample(Scene):
    def construct(self):
        text = MarkupText('<span underline="single">underlined</span>')
        self.add(text)

System specifications

Manim Community v0.18.0

dandavison avatar Jan 15 '24 13:01 dandavison

According to the Pango documentation (Pango is the external python library used here), it should be <u>...</u> which actually works

class MarkupExample(Scene):
    def construct(self):
        text = MarkupText("<u>underlined</u>")
        self.add(text)

https://docs.gtk.org/Pango/pango_markup.html

uwezi avatar Jan 15 '24 14:01 uwezi

I have currently not set up a development branch again on my system - perhaps someone could quickly change the docstring? Line 889 in text_mobject.py - or rather line 897 in the current version on Github...

bild

uwezi avatar Jan 15 '24 14:01 uwezi