manim icon indicating copy to clipboard operation
manim copied to clipboard

Fix Circumscribe (#2563)

Open skyyce opened this issue 3 years ago • 0 comments

Overview: What does this pull request change?

Fix the problem that the argument run_time is not successfully passed to Circumscribe when it is passed inside Scene.play() but outside Circumscribe(). Change the superclass of Circumscribe from Succession to AnimationGroup and call the class Succession later in the class Circumscribe when there are multiple animations in succession.

Motivation and Explanation: Why and how do your changes improve the library?

bugfix(#2563) Now the run time of circumscribe can be set in Scene.play()

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • [ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • [ ] If applicable: newly added functions and classes are tested

skyyce avatar Aug 05 '22 03:08 skyyce