manifold
manifold copied to clipboard
ManifoldScholar
Refactor form input styles
These kinds of selectors are getting out of hand and causing a lot of difficulty refactoring some of the form input labeling. These styles need to be a little more modular and manageable.
https://github.com/ManifoldScholar/manifold/blob/master/client/src/theme/Components/global/forms/_form-inputs-secondary.scss#L92
https://github.com/ManifoldScholar/manifold/blob/master/client/src/theme/Components/global/forms/_form-inputs-primary.scss#L11
here too
@dananjohnson Could you please take a look at this and let me know if you think this is still relevant/necessary? Thanks.
@zdavis I think this is still relevant. There's been some incremental progress on this, but BE forms (.form-secondary) in particular still have a lot of heavily-nested selectors that could benefit from becoming more modular.
Thank you for taking the time to open this feature request. The Manifold team reviewed this issue during our bi-weekly meeting and the consensus is that this feature makes sense and is in keeping with our overall vision for the platform. Moreover, we see this request as a viable candidate for development under our current available funding. We’re adding an “accepted” label to this request to indicate that it’s within scope and possibly within budget.
The next step is for us to estimate the work involved with this and add it to our feature backlog. Our acceptance of the issue is not a promise that it will be implemented. We will balance this request against the other accepted requests and do our best to implement it within our current available funding.
This was an automated message, but please don't hesitate to reply. Our team watches these issues closely and will respond as soon as we're able to!
We'll address this outside of this issue as part of a larger form refactoring.