mangopay2-php-sdk icon indicating copy to clipboard operation
mangopay2-php-sdk copied to clipboard

Published 20 hours ago • verified publisher icon Mangopay

Update property data types and API parameter types

Open mralaminahamed opened this issue 9 months ago • 9 comments

Currently, some properties and API parameter types in the mangopay2-php-sdk library may not align with the latest version of the Mangopay API. This can lead to compatibility issues, data type mismatches, or incorrect data being passed to the API.

I propose updating the property data types and API parameter types in the library to ensure they accurately reflect the latest Mangopay API specifications. This will improve compatibility, prevent potential bugs, and ensure the library remains up-to-date with the API changes.

Proposed Changes:

  1. Review API Documentation: Thoroughly review the latest Mangopay API documentation to identify any changes in data types or parameter types for various API endpoints.

  2. Update Property Data Types: Update the data types of relevant properties in the library's model classes to match the API specifications.

  3. Update API Parameter Types: Update the parameter types in the library's API client classes to match the API specifications.

  4. Update Examples and Documentation: Update any examples or documentation within the library to reflect the changes in data types and parameter types.

  5. Add Test Cases: Add or update test cases to ensure the changes in data types and parameter types are thoroughly tested and validated.

Potential Challenges:

  • Ensuring all relevant data types and parameter types are identified and updated correctly.
  • Maintaining backward compatibility, if necessary, for existing applications using the library.
  • Updating any external dependencies or related libraries that may be affected by the changes.

Benefits:

  • Improved compatibility with the latest Mangopay API.
  • Reduced chances of data type mismatches or incorrect data being passed to the API.
  • Better maintainability and extensibility of the library as it remains aligned with the API specifications.
  • Increased confidence in the library's functionality and reliability.

I'm willing to work on this update and would appreciate any feedback or suggestions from the project maintainers and community members.

mralaminahamed avatar May 08 '24 09:05 mralaminahamed

@williamdes, @florentdestremau, I kindly request your attention and cooperation regarding the following proposed update for the mangopay2-php-sdk library.

mralaminahamed avatar May 08 '24 09:05 mralaminahamed

I am not a MangoPay team here, only a contributor :) Ping me on code reviews please

williamdes avatar May 08 '24 09:05 williamdes

Thanks you and i will proceed with making a pull request (PR).

But any MangoPay team member here?

mralaminahamed avatar May 08 '24 10:05 mralaminahamed

@iulian03 are you a MangoPay Team member?

mralaminahamed avatar May 08 '24 10:05 mralaminahamed

I'm not a mangopay member either (and they are not very active here anyway)

florentdestremau avatar May 10 '24 10:05 florentdestremau

how can merge my pr to main branch?

mralaminahamed avatar May 10 '24 11:05 mralaminahamed

how can merge my pr to main branch?

Please stop such a behavior, people need time to review Ping for review after less than a week is quite rude

williamdes avatar May 10 '24 12:05 williamdes

Please stop such a behavior, people need time to review Ping for review after less than a week is quite rude

I apologize for my inquiry. I'm asking out of need as I work with a product utilizing the MangoPay PHP SDK. My responsibilities include maintaining the MangoPay integration.

mralaminahamed avatar May 10 '24 13:05 mralaminahamed

Keep this in mind for all open source projects ;)

Same, waiting on #642 Let's wait and see If no news in some weeks I will contact them by email

williamdes avatar May 11 '24 07:05 williamdes