BACnet4J icon indicating copy to clipboard operation
BACnet4J copied to clipboard

BACnet - Vendor Name Issue

Open drd888 opened this issue 4 years ago • 1 comments

The proper value for the vendor ID is returned but the vendor name is not being populated.
I did not quite a bit of static analysis but could not find the issue.

I am using: com.serotonin.bacnet4j.RemoteDevice getVendorName()

drd888 avatar Apr 02 '21 18:04 drd888

The vendorName is pupulated from remote Device object property. Same logic as for vendorIdentifier, its just different type:

package com.serotonin.bacnet4j.type.enumerated;

public class PropertyIdentifier extends Enumerated {
  // ...
  public static final PropertyIdentifier vendorIdentifier = new PropertyIdentifier(120);
  public static final PropertyIdentifier vendorName = new PropertyIdentifier(121);
  // ...
}

It happens that these values are somewhat not matching. For example producer is one firm, but firmware/board for electronics is shipped by another.

splatch avatar Apr 03 '21 22:04 splatch