slideout icon indicating copy to clipboard operation
slideout copied to clipboard

Published 20 hours ago • verified publisher icon Mango

Support for 0 padding, tolerance and duration

Open anmatika opened this issue 5 years ago • 1 comments

Not sure if this is by design or a bug in the library. If this is a bug please consider this PR.

Setting 0 values on initialization for padding, tolerance, or duration is not possible with the current implementation since 0 values will become their default values.

For example, padding set to 0 will become 256. If using the library so it would behave as an overlay menu, having a possibility to set 0 padding is important.

This PR will add the possibility to set 0 values for padding, tolerance, and duration.

For more info, there's an issue for this: https://github.com/Mango/slideout/issues/266

anmatika avatar Nov 09 '18 07:11 anmatika

Coverage Status

Coverage increased (+0.5%) to 70.414% when pulling fd5f9a39f7830b94b2183978779a3936ab494c13 on anmatika:support-0-padding-tolerance-duration into 6eb8440ddc7e94194723f86f6580de4d101762a3 on Mango:master.

coveralls avatar Nov 09 '18 07:11 coveralls