Maxime Mangel

Results 1077 comments of Maxime Mangel

Totally for this one :) It's how I update my bindings now and it's so much easier/natural to use

The error from F# is indeed "funny" when you do: ```fs type URL = int type Test () = static member fileURLToPath: string -> string = jsNative static member fileURLToPath:...

Also, if the code looks ugly or is not possible to be supported. I guess we could only support one of the methods with an annotation stating it. For example,...

Oh I didn't know. If what @alfonsogarciacaro says is right then it's better than any hacks if we need `static member` :)

@whitetigle Which `format` API are you speaking about? For [url.format(urlObject)](https://nodejs.org/dist/latest-v10.x/docs/api/url.html#url_url_format_urlobject) the following code works: ```fs // url.format({ // protocol: 'https', // hostname: 'example.com', // pathname: '/some/path', // query: { //...

Ok, I have a working version which supports both `format` method. Please note, that I wrote the binding from scratch without thinking if this is breaking the existant API and...

Ah yes indeed: `let [] URL: Url.URLType = jsNative` is compiled to something like `URL` while ```fs [] let URL: Url.URLType = jsNative ``` compiles to ```js var url =...

I discover yesterday that we have a `addEventListener` listening for the URL change. It's could be one of the cause. In Elmish the `toNavigable` module check if the previous URL...

I don't know yet. I just discover this event listener yesterday when reviewing the PR for `#reset`. I am planning to remove current listener and use Elmish navigation module so...

Indeed the reason being they are not `toast` like we have on our mobile phone. On mobile, you can have only one toast displayed at the time. They are more...