Maxime Mangel

Results 1077 comments of Maxime Mangel

Fix path when auto decoding unions

Thank you Alfonso. How is the `sideEffects` taking place ? I mean Fable is the one responsible to compile the Thoth.Json library so I don't think webpack or any other...

Fix path when auto decoding unions

I see, thank you for the explanations :)

simulate this Test Local Machine Timezone to fix this

I didn't know that thank you for sharing 👍 If we do that perhaps we should "set" the timezone locally for the test and reset it to it's old value...

simulate this Test Local Machine Timezone to fix this

Another track to explore, would be to take a look at existing NPM package working with timezone like date library or parser and see if we can spot how they...

Decoding Map<string,string> inside a record inside an erased discriminated union seems to produce an incorrect type - standard F# Map functions won't work on it

Ok, I can confirm that there is a problem when the map is inside a record inside a discriminated union. Reproduction code using Thoth.Json tests modules. ```fs module Tests.Encoders open...

Decoding Map<string,string> inside a record inside an erased discriminated union seems to produce an incorrect type - standard F# Map functions won't work on it

When looking at the generated JSON it seems like when the "map is inside a record inside a DU" the JSON output is different from what is expected for a...

Decoding Map<string,string> inside a record inside an erased discriminated union seems to produce an incorrect type - standard F# Map functions won't work on it

The problem is caused by `[]` attributes, if you remove it then the generated JSON is correct. ``` test #1: { "Description": "test-project", "Membership": { "maxime": "user", "rmunn": "admin" }...

Decoding Map<string,string> inside a record inside an erased discriminated union seems to produce an incorrect type - standard F# Map functions won't work on it

It seems like `Erased` union are considered `System.Object` in Fable reflection API and because we pass it as it is we didn't had an error reported. Erased unions are not...

Decoding Map<string,string> inside a record inside an erased discriminated union seems to produce an incorrect type - standard F# Map functions won't work on it

Actually `obj` support is needed as it used to support `null` encoding/decoding. When disabling it the only tests that are failing about `null` handling. I think the issue is on...

Allow user to customize even the default encoders

Well, one problem we can have is that we start supporting others serialization representation for one type I might have to support it for all. And if I do it...