Manga-Manager icon indicating copy to clipboard operation
Manga-Manager copied to clipboard

Make Volume tag accept decimals

Open Roshri opened this issue 1 year ago • 8 comments

Is your feature request related to a problem? Please describe. I have some volumes for specific manga that have decimal on them, and Manga Manager doesn't accept the dot (.) separator to represent it on the volume tag.

Example of one series image

Describe the solution you'd like Ideally, I'd like to have it so I can have the decimal in between integers, so 10.5 would be between 10 and 11 when displaying in Kavita. (And not whatever fuckery w10 does where it shows the decimal first lol)

Roshri avatar Jul 15 '23 14:07 Roshri

Related: #174

ThePromidius avatar Jul 15 '23 15:07 ThePromidius

Technically float values are not supported by comicinfo schema 🤔 Thougths on this? yeah works on kavita i guess.... but trying to stay consistent. Also what's the point in having decimal values? This is a personal query. How does that work?

ThePromidius avatar Jul 22 '23 19:07 ThePromidius

Never saw your reply, sorry for the late response. I have some manga that releases bonus volumes bundled with limited edition of the physical book, which are commonly labelled as vol XX.5 as they are intended to be read after said volume. Currently, specials can cover for this in a limited manner since you have to switch tabs and remember where you're supposed to read the .5 volume

Roshri avatar Sep 21 '23 01:09 Roshri

Perhaps we can raise a spec change request supporting float volumes and then move forward with implementation, regardless of if it merges or not.

@Roshri would you be able to provide some official Volume x.5 samples?

majora2007 avatar Jan 09 '24 18:01 majora2007

I can email you the .cbz for vol 10.5 of the series I pictured above. It's a small ilustration book with a short story, it came bundled with vol 10

Roshri avatar Jan 09 '24 20:01 Roshri

Roshri, would you be willing to open a spec enhancement here? https://github.com/anansi-project/comicinfo/issues

I'm not saying it will get approved, but it is the first step to allowing MM to change against the spec (like we did with LocalizedSeries in MM/Kavita)

majora2007 avatar Jan 11 '24 12:01 majora2007

Just following up @Roshri (or anyone interested), nothing has been opened requesting this on the spec.

majora2007 avatar Feb 11 '24 14:02 majora2007

I forgot, I'm on vacation right now, I'll open it when I come back! Thanks for the reminder

edit: just created the issue

Roshri avatar Feb 11 '24 15:02 Roshri