[WIP] Unclutter commit monitor

[Fryguy]

This PR unclutters the core of the CommitMonitor by removing the whole categorization notion of separate workers. All workers will receive the branch_id and the new_commits on that branch, and it is up to the worker how they want to deal with that.

@bdunne Please review.

PR is WIP because I haven't tested enough yet.

[Fryguy]

First 2 commits are flattening the commit_range directory. The last commit is the big change to the CommitMonitor

[Fryguy]

Did a quick first pass on testing and something is wrong. It seems to execute all of the handlers even if there haven't been any changes to the branch. I must have removed a check somewhere in all those deletions. No issues though when the actual workers run.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits https://github.com/Fryguy/miq_bot/compare/b30558e2dc32850601dc1b95352365cfb6b3439c~...879a668368ac4bb3056f6c21a6b634f74a0cd19a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 32 files checked, 330 offenses detected

**

• [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Haml - missing config files

app/workers/commit_monitor.rb

• [ ] :exclamation: - Line 12, Col 22 - Rails/FilePath - Please use Rails.root.join('path', 'to') instead.

app/workers/commit_monitor_handlers/bugzilla_commenter.rb

• [ ] :exclamation: - Line 37, Col 5 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• [ ] :exclamation: - Line 67, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• [ ] :exclamation: - Line 70, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

app/workers/commit_monitor_handlers/bugzilla_pr_checker.rb

• [ ] :exclamation: - Line 40, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• [ ] :exclamation: - Line 46, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• [ ] :exclamation: - Line 49, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• [ ] :exclamation: - Line 62, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• [ ] :exclamation: - Line 65, Col 7 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

app/workers/commit_monitor_handlers/github_pr_commenter/diff_filename_checker.rb

• [ ] :exclamation: - Line 42, Col 10 - Rails/TimeZone - Do not use Time.parse without zone. Use one of Time.zone.parse, Time.current, Time.parse.in_time_zone, Time.parse.utc, Time.parse.getlocal, Time.parse.iso8601, Time.parse.jisx0301, Time.parse.rfc3339, Time.parse.to_i, Time.parse.to_f instead.

app/workers/commit_monitor_handlers/path_based_labeler.rb

• [ ] :warning: - Line 27, Col 3 - Lint/HandleExceptions - Do not suppress exceptions.

app/workers/commit_monitor_handlers/rubocop_checker.rb

• [ ] :exclamation: - Line 24, Col 5 - Rails/Present - Use if @results["files"].present? instead of unless @results["files"].blank?.

app/workers/commit_monitor_handlers/rubocop_checker/message_builder.rb

• [ ] :exclamation: - Line 21, Col 19 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• [ ] :exclamation: - Line 21, Col 19 - Style/PercentLiteralDelimiters - %w-literals should be delimited by ( and ).

app/workers/commit_monitor_handlers/rubocop_checker/rubocop_results_filter.rb

• [ ] :exclamation: - Line 33, Col 19 - Performance/RedundantMatch - Use =~ in places where the MatchData returned by #match will not be used.
• [ ] :exclamation: - Line 33, Col 19 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

spec/workers/commit_monitor_handlers/github_pr_commenter/diff_content_checker_spec.rb

• [ ] :exclamation: - Line 11, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 12, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_lines_not_in_the_diff/example.rb

• [ ] :exclamation: - Line 2, Col 10 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• [ ] :exclamation: - Line 3, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 4, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_results_generating_multiple_comments/lots_of_issues.rb

• [ ] :warning: - Line 100, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 101, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 102, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 103, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 104, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 105, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 106, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 107, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 108, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 109, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 110, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 111, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 112, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 113, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 114, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 115, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 116, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 117, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 118, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 119, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 120, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 121, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 122, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 123, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 124, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 125, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 126, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 127, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 128, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 129, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 130, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 131, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 132, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 133, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 134, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 135, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 136, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 137, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 138, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 139, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 140, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 141, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 142, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 143, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 144, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 145, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 146, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 147, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 148, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 149, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 150, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 151, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 152, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 153, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 154, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 155, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 156, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 157, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 158, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 159, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 160, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 161, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 162, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 163, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 164, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 165, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 166, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 167, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 168, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 169, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 170, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 171, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 172, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 173, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 174, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 175, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 176, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 177, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 178, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 179, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 180, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 181, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 182, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 183, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 184, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 185, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 186, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 187, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 188, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 189, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 190, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 191, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 192, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 193, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 194, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 195, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :warning: - Line 196, Col 5 - Lint/DuplicatedKey - Duplicated key in hash literal.
• [ ] :exclamation: - Line 100, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 101, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 102, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 103, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 104, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 105, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 106, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 107, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 108, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 109, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 10, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 110, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 111, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 112, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 113, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 114, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 115, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 116, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 117, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 118, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 119, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 11, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 120, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 121, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 122, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 123, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 124, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 125, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 126, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 127, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 128, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 129, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 12, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 130, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 131, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 132, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 133, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 134, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 135, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 136, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 137, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 138, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 139, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 13, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 140, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 141, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 142, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 143, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 144, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 145, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 146, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

[miq-bot]

...continued

• [ ] :exclamation: - Line 147, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 148, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 149, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 14, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 150, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 151, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 152, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 153, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 154, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 155, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 156, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 157, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 158, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 159, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 15, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 160, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 161, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 162, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 163, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 164, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 165, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 166, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 167, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 168, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 169, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 16, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 170, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 171, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 172, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 173, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 174, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 175, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 176, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 177, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 178, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 179, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 17, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 180, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 181, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 182, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 183, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 184, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 185, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 186, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 187, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 188, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 189, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 18, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 190, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 191, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 192, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 193, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 194, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 195, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 196, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 19, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 20, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 21, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 22, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 23, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 24, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 25, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 26, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 27, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 28, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 29, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 2, Col 10 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• [ ] :exclamation: - Line 30, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 31, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 32, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 33, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 34, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 35, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 36, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 37, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 38, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 39, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 3, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 40, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 41, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 42, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 43, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 44, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 45, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 46, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 47, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 48, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 49, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 4, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 50, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 51, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 52, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 53, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 54, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 55, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 56, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 57, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 58, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 59, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 5, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 60, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 61, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 62, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 63, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 64, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 65, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 66, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 67, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 68, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 69, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 6, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 70, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 71, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 72, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 73, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 74, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 75, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 76, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 77, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 78, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 79, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 7, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 80, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 81, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 82, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 83, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 84, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 85, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 86, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 87, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 88, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 89, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 8, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 90, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 91, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 92, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 93, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 94, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 95, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 96, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 97, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 98, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 99, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 9, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_results_with_offenses/coding_convention.rb

• [ ] :exclamation: - Line 3, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 4, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_results_with_offenses/ruby_syntax_error.rb

• [ ] :bomb: :boom: :fire: :fire_engine: - Line 3, Col 1 - Lint/Syntax - unexpected token kEND (Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_results_with_offenses/ruby_warning.rb

• [ ] :warning: - Line 3, Col 5 - Lint/UselessAssignment - Useless assignment to variable - unused_variable.

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_void_warnings_in_spec_files/non_spec_file_with_void_warning.rb

• [ ] :warning: - Line 2, Col 13 - Lint/Void - Operator == used in void context.

spec/workers/commit_monitor_handlers/rubocop_checker/data/with_void_warnings_in_spec_files/spec/non_spec_file_in_spec_dir_with_void_warning.rb

• [ ] :warning: - Line 2, Col 13 - Lint/Void - Operator == used in void context.

spec/workers/commit_monitor_handlers/rubocop_checker/message_builder_spec.rb

• [ ] :warning: - Line 44, Col 54 - Lint/AmbiguousRegexpLiteral - Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.
• [ ] :exclamation: - Line 21, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 34, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 40, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 43, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 50, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 52, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 59, Col 1 - Layout/IndentHeredoc - Use 2 spaces for indentation in a heredoc by using <<~ instead of <<-.
• [ ] :exclamation: - Line 64, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• [ ] :exclamation: - Line 7, Col 24 - Style/WordArray - Use %w or %W for an array of words.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[Fryguy]

Reopening cause I still think this is the right approacj

[miq-bot]

This pull request is not mergeable. Please rebase and repush.