miq_bot icon indicating copy to clipboard operation
miq_bot copied to clipboard

regex in notification monitor for WIP is insufficient

Open Fryguy opened this issue 8 years ago • 1 comments
trafficstars

https://github.com/ManageIQ/miq_bot/blob/96d28fab4f605844b02b50911cba2adc114d49f6/lib/github_service/issue.rb#L7 is insufficient as it only looks for WIP at the start. This can be better handled by reusing the pr_title_tags method: https://github.com/ManageIQ/miq_bot/blob/e81985b7bef0227b963a8372a444178a56a462fe/app/models/branch.rb#L65-L67 , which is what's used by the wip_labeler worker.

See ManageIQ/manageiq#14551 for an example of where it double-wipped a PR.

Fryguy avatar Mar 28 '17 22:03 Fryguy

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

miq-bot avatar Jun 11 '20 22:06 miq-bot