miq_bot icon indicating copy to clipboard operation
miq_bot copied to clipboard

General enable/disable support

Open Fryguy opened this issue 8 years ago • 2 comments

We have some enable/disable support in a number of workers, but many don't have it, such as the RubocopChecker, which is requested in #244. Also, the enable/disable support is a little inconsistent, so I'm thinking something more generic across the board would be very useful.

Additionally, this might allow us to separate out any private things (such as where the bot needs access to behind-the-firewall resources) from public things (such as where the bot may want to respond to a webhook), and allow us to run 2 bot instances (one internal and one external).

I'm thinking the configuration could be something similar to how rubocop itself works. So, within the bot we specify sensible defaults for most repos:

AllWorkers:
  Enabled: true
SqlMigrationChecker:
  Enabled: false

Then there can optionally be an .miq-bot.yml file within each repo where they can choose to enable or disable a specific worker (or in the future provide other options that can be overridden). So, for example, in manageiq-ui-service, they don't need the RubocopChecker at all since their linting is all done in Travis. Thus, they might have a file like:

RubocopChecker:
  Enabled: false

Fryguy avatar Jan 06 '17 19:01 Fryguy

:+1:

bdunne avatar Jan 06 '17 20:01 bdunne

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

miq-bot avatar Jun 11 '20 22:06 miq-bot