manageiq icon indicating copy to clipboard operation
manageiq copied to clipboard

[WIP] Allow creation of non-leaf providers in specs

Open agrare opened this issue 2 years ago • 8 comments

We don't want to allow the creation of non-leaf providers in production/development but for specs this requirement pushes us to having specific provider plugins be the prototypical providers for these types which goes against our general "no specific providers in specs" even if it doesn't look like it.

agrare avatar Feb 08 '23 15:02 agrare

Checked commit https://github.com/agrare/manageiq/commit/3cde2c14841d6f3632ef70fea014af72d73acbc1 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cookie:

miq-bot avatar Feb 08 '23 15:02 miq-bot

This is where I was suggesting that we include the DummyProvider in test, and then the DummyProvider can have one of each kind of manager/provider in it.

Would that be a better approach? Or is this more of a "phase 1" to getting there?

Fryguy avatar Feb 23 '23 21:02 Fryguy

Agreed with the DummyProvider suggestion. I wrote stub_supports to aid in the use of Dummy's.

kbrock avatar Apr 13 '23 22:04 kbrock

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Jul 17 '23 00:07 miq-bot

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot avatar Oct 30 '23 00:10 miq-bot

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot avatar Feb 05 '24 00:02 miq-bot

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot avatar May 06 '24 00:05 miq-bot

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot avatar Aug 12 '24 00:08 miq-bot